Design comparison
SolutionDesign
Solution retrospective
All feedbacks are welcome
Community feedback
- @thisisharsh7Posted about 2 years ago
Hey Divine, Great Job ! your solution seems to work fine and it is responsive too. But there area some improvement which could be made
- For aligning the whole content to the center of the screen you should not use
body {display: block; margin: 8px; }
instead try thisbody{min-height: 100vh; display: flex; flex-direction: column; align-items: center; justify-content: center;}
- There is no need to set every container height and width manually by the code and if you really want then use min-, max-width or min-, max-height like
.item{width: 200px; height:400px;}
this code of yours is not going to give responsiveness to the page instead use this.item{max-width: 200px; min-height:400px;}
and removep{width: 25ch;}
too.
Hope it helps....
Marked as helpful0 - For aligning the whole content to the center of the screen you should not use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord