Design comparison
Solution retrospective
Please help me suggest a better way of creating the buttons and layout
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Emmanuel, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden="true" to be ignored by screen readers and to avoid redundancy and repetition.
Avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remI liked that you put
max-width
so the elements don't stretch but as you can see in higher resolutions, the background color is different, to fix that you can put a max-width on the div that only has the content and not on the one has the background color!The rest is great!
I hope it helps... 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord