Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="attribution"> with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span> They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  LINKS 🔖:

  • The WCAG says that you should not describe the image text in this situation but the link function.

  ---

  • When an image is the only content of a link, the text alternative for the image describes the unique function of the link.

  ---

  • If you think that the text within the image should be described to screen readers users, you have to change the structure of your HTML, excluding the image from the link, for instance.

  ---

  <a href="comics.html">Comics</a>
  Image of the day:
     <img src="..." alt="If the clouds ever did go down would it be called fog?" />
  

  ---

  • or adding the description after (note that using aria-describedby the description might be hidden)

  ---

  <a href="comics.html" aria-describedby="desc"><img src="..." alt="Comics" /></a>
  

  ---

  • Summary, add a aria-describedby to <a> element and add an empty alt="" to the <img> inside <a>

  ---

  • EG: <a href="somewhere" aria-describedby="Someone's facebook profile">

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Lucky Avbunufe•190

  @StanmancerPosted over 1 year ago

  @0xAbdulKhalid Thanks you so much 🙏 for your feedback. I'll revisit my code and make adjustments.

  • Concerning the <div class="attribution">...<\div>, i already have a <footer> element. Is it okay to have two or more of the <footer> element??

  0