Responsive clipboard landing page Only CSS

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey Peally!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You can set the min-height of your body to 100vh.
  • You should use <main class="card"> instead of <div class="card">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can increase your font-size and maybe add some margins and padding to your elements
  • You shouldn't use the alt attribute on an anchor tag

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0

  ---

  

  Peally•200

  @PeallyzPosted over 2 years ago

  @Samadeen Thank you very much for these advices

  Can you just explain me some things about it ? What does it change to give an height to the body ? I do not have a card div, you probably mean that i should have a real <main> between the header and the footer

  I'm working on a bigger screen than 1440px. In my screen it was looking like very similar as the preview jpeg but in fact it's not. Do you have some advice to realize which font or padding/margin is the most adapted ?

  Is the alt on the anchor tag a SEO issue ?

  I'll still apply your tips before understanding them and i'll looking for some explanation

  0

  

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  @Peallyz Hey Fam

  Giving your body a min-height of 100vh simply means your webpage will contain 100% of your screen size regardless of how long your screen is.

  Pardon me I meant your main tag

  And yes the alt on the anchor tag is a SEO issue.

  0