Design comparison
Solution retrospective
Hello every body, I accept all advices and all notes, feel free to leave a comment. thank's you all.
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello again Nouredine, it seems that you have improve since your product card challenge, this is a much harder challenge and you manage to complete it, congrats!
Your CSS doesn't seem to be bad (you can do some improves) but you did get the responsiveness working and thats great, would like to focus my feedback this time in your html tags!
Try to use a
main
tag, this is important, here is where the main content of your page should be, for example, thesupercharge div
and thesnippets div
would fit perfectly on amain
tag, separated in two sections, you should also define the rest of your related content withsections
instead of just alldivs!
the same goes for the footer, you are even naming itfooter
but you are not using the html tag!Anyway, apart from those html changes and improvements, you did impress me with the difference between this and your last project.
Hope my feedback helps you, keep going on those challenges!
Marked as helpful0@elghaouatPosted about 2 years ago@DavidMorgade thank's alot my friend, I followed you in github hopefuly to contact in private, and i was waiting for your comment 😋 I really appreciate your feedback and thank's for your note. If you accept to chat with you i would ask you for something and more explainations. Thank's again
1@DavidMorgadePosted about 2 years ago@elghaouat Yeah! you can contact me on github or here and I will try to help you as much as I can!
Marked as helpful0@elghaouatPosted about 2 years ago@DavidMorgade how can you contact you, i didn't find how to send you message
0@DavidMorgadePosted about 2 years ago@elghaouat send me a DM message on my twitter acc https://twitter.com/MeSabeAgridulce
Marked as helpful0@elghaouatPosted about 2 years ago@DavidMorgade i followed you my profile: https://mobile.twitter.com/Elgnoure
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord