Skip to content
Submitted about 2 years ago

Responsive Clipboard landing page created with CSS Flexbox

Mihael•260
@mihaelpavlakovic
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Clipboard landing page
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hii everyone, this is the 14th challenge I have tried to recreate. I'm so happy about how it turned out, but I think I could further improve in writing cleaner code.

It would be helpful for my future growth if you could point me in the right direction. For example, I'm interested in potentially better solutions for this challenge. In which area do I need to improve, and what do you recommend that I should implement? What are some best practices that I haven't got right?

Thanks for your attention and all the future feedback.

Community feedback

  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Mihael, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    0
    Mihael•260
    @mihaelpavlakovicPosted about 2 years ago

    @AdrianoEscarabote Thanks for the response I will try and implement landmarks. In terms of other improvements (rem units) is there anything specific I should change since my project was created with rem units in mind? The only exceptions are box-shadow and the main font-size property.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord