Responsive chanel product page

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Andrusik, Congratulations on completing this challenge!

  I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:

  You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Sathya D•310

  @satzzzzz07Posted about 2 years ago

  Hey there, Great work on your first solution! Design looks good. There are few suggestions:

  1. Try to use the fonts mentioned in the style-guide file. You can import the fonts from google fonts. Its a simple process, choose the font and then import them into your css or html files. You can use the font style using font-family css property.

  2. On mobile-screen, the border-radius of the image is inconsistent. You can add border-radius on top left and right sides instead of existing top-left and bottom-left sides. check out for border-radius

  3. Try to match the font sizes in the design. You can always refer to the design files.

  4. Also the image on the mobile-screen looks a bit messy. You can check out properties like object-fit check here

  Aside these, excellent work again and happy coding :) 👍

  Marked as helpful

  0
• 

  Andrusik•270

  @Andrusik1Posted about 2 years ago

  I don't use font mentioned in design file for simple reason, bcs when i used it the edges of the font was cut and it look so weird, do u know how to solve it?

  0