Submitted 6 months ago

Responsive Card

Andrew G. Ayad•100

@andrew-g-ayad

Preview site View code

This is a solution for...Blog preview card

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Looks Identical to the original design
Used semantic HTML
Cared about tiny details

What challenges did you encounter, and how did you overcome them?

I realized that different software tools treat borders differently. This made a 2px difference in the overall width of the card, But I managed to work around this by decreasing the overall padding to make it look pixel-perfect. so here's a list of challenges I did encounter:

Borders are treated differently between software tools
In this project I needed to specify the correct image height

What specific areas of your project would you like help with?

I wish to understand the pixel-perfect difference in padding-margin added by default to the text in design software. because I find that the vertical space between an element and a text can be larger by a few pixels than what the software shows/tells.

Community feedback

Bernardo Poggioni•5,280
@R3ygoskiPosted 6 months ago
Hello Andrew, first of all, I'd like to congratulate you on creating a solution that is truly identical to the proposed design, my sincere congratulations! It's perfect.

I'd like to make an observation: the ::hover pseudo-class is missing on the card. When hovering over the card, its shadow should increase slightly towards the bottom right corner.

And I'd like to give you a tip about semantic HTML. The semantic structure is very good, but there are some parts that could be more semantic:

<div class="card">: It would be more appropriate to use an <article>, because the content in this part is self-explanatory and independent of the rest of the page context.

<span class="card__date">: It would be more appropriate to use a <time> element.

<div class="author">: It would be more appropriate to use a <footer>, as this is the end of a content section.

Sorry, I didn't quite understand your question. I didn't understand what you meant by the software you referred to.

Again, congratulations on your project, it's amazing. If anything is unclear, please comment below and I'll try to help as best as I can.
Marked as helpful
2
Andrew G. Ayad•100
@andrew-g-ayadPosted 6 months ago
@R3ygoski Thanks! You really corrected my thinking about Semantic HTML! I changed the HTML and added the missing hover effect as you suggested.

Thank you a LOT!!
1
Juan Camilo Trujillo•110
@DarkKiller31Posted 6 months ago
perfect
1
Abdul Khaliq 🚀•72,580
@0xabdulkhaliqPosted 6 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have a suggestion regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord