Design comparison
Solution retrospective
- Looks Identical to the original design
- Used semantic HTML
- Cared about tiny details
I realized that different software tools treat borders differently. This made a 2px difference in the overall width of the card, But I managed to work around this by decreasing the overall padding to make it look pixel-perfect. so here's a list of challenges I did encounter:
- Borders are treated differently between software tools
- In this project I needed to specify the correct image height
I wish to understand the pixel-perfect difference in padding-margin added by default to the text in design software. because I find that the vertical space between an element and a text can be larger by a few pixels than what the software shows/tells.
Community feedback
- @R3ygoskiPosted 7 months ago
Hello Andrew, first of all, I'd like to congratulate you on creating a solution that is truly identical to the proposed design, my sincere congratulations! It's perfect.
I'd like to make an observation: the
::hover
pseudo-class is missing on the card. When hovering over the card, its shadow should increase slightly towards the bottom right corner.And I'd like to give you a tip about semantic HTML. The semantic structure is very good, but there are some parts that could be more semantic:
<div class="card">
: It would be more appropriate to use an<article>
, because the content in this part is self-explanatory and independent of the rest of the page context.<span class="card__date">
: It would be more appropriate to use a<time>
element.<div class="author">
: It would be more appropriate to use a<footer>
, as this is the end of a content section.
Sorry, I didn't quite understand your question. I didn't understand what you meant by the software you referred to.
Again, congratulations on your project, it's amazing. If anything is unclear, please comment below and I'll try to help as best as I can.
Marked as helpful2@andrew-g-ayadPosted 7 months ago@R3ygoski Thanks! You really corrected my thinking about Semantic HTML! I changed the HTML and added the missing hover effect as you suggested.
Thank you a LOT!!
1 - @0xabdulkhaliqPosted 7 months ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have a suggestion regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS π:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord