Design comparison
Community feedback
- @Davic15Posted over 1 year ago
Hi. Good job. Looks great.
I see that you have some problems with your accessibility report, to correct them you must do the following, firstly in your index.html file in the <div id="root"></div> tag, change it to <main id="root "></main>.
In addition, in the images you use, you must add the alt attribute inside the src tag, it allows you to write the description of the image, in case the image does not work.
For reasons of semantics with the labels, you have problems in your report.
Modify that, let's see how it goes.
Marked as helpful0 - @RbkHerediaPosted over 1 year ago
Hello Franklin! Thank you very much for your feedback, this type of comments helps me a lot to improve my weaknesses. I was working on improving my accessibility and in this case I got 100% in lighthouse. Fixed the first div in the html file, added alt attributes to the images, and my titles are positioned. I hope you can check my progress. Greetings!
0@Davic15Posted over 1 year ago@RbkHeredia Hello again Rebecca.
I see that you do not have accessibility problems, I congratulate you. But now I see that you have 5 HTML validation report.
Let's fix them.
According to the MSDN, Sections should always have a heading. You must specify a heading h2 - h6. Or you can change the section to a div or other container.
You have a problem with the button and the anchor tag, to fix it, you can make the anchor tag look like a button, or you can just use the button with some CSS, you can't use the button inside the anchor tag.
Update the project and let's see how it goes.
See you later.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord