Responsive card using Flexbox and SASS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  It all looks a lot smaller than the design on desktop preview, but looks good for me on mobile. The image goes very small in height on mobile landscape so consider adding a larger min-height on that.

  1

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Have a rethink of your html structure. Those numbers don't make sense as h2s.

  1

  

  Ivan Mrsic•85

  @imrsic-devPosted over 3 years ago

  @grace-snow thank you for your feedback I appreciate it, sorry for my late reply.

  I used HTML structure hierarchy from h1 to h2 in this case. I think sizes shouldn’t matter in that case, but I could be wrong.

  0

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  @imrsic-dev it’s not the order or sizes that are the issue. It’s that numbers like “10k” can never be headings as they carry no meaning. They have to be in the same semantic element as the words that follow them. 3 bullet points make sense for those stats, three sets of headings and paragraphs do not

  Marked as helpful

  1

  

  Ivan Mrsic•85

  @imrsic-devPosted over 3 years ago

  @grace-snow ok, now I understand what you meant, ok I agree with you, headings weren't the best solution. So you propose <ul> with <li> as better solution?

  1