
Design comparison
Community feedback
- P@fringe4lifePosted 2 months ago
Hi, I am not sure if this should really be in the main tag as it seems likely there would be multiple such cards on the page, that automated test cannot tell the difference between a card and a real web page.
I also have learned that it is best to use
min-height:100dvh;
instead ofheight:100dv;
as the latter would cut content whereas the former would allow for overflow.It doesn't matter to much in this scenario as you only did that to center it on the page, but going forward you could run into trouble from it.
Your code is very readable, so great job on that!
The end result is that your result is very consistent with the design.
Congrats.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord