Responsive card using CSS flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • The <br> tag is often used to create line breaks, but it doesn't convey any semantic meaning. When a screen-reader reads the text, it will break the flow of reading at the line break tag, which can be confusing for users. More information here.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

    screenshot-imgur (landscape mode)📸

  • Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the width property with a percentage value.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted over 1 year ago

  @MelvinAguilar Thanks so much, currently working on it

  0

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted over 1 year ago

  @MelvinAguilar On the break tag "<br>", i read through the resource you gave me and still didn't what I didn't do right on the "<br>". Although I got something valuable -

  "Do not use <br> to create margins between paragraphs; wrap them in <p> elements and use the CSS margin property to control their size". Please is it possible to point directly from the code where I didn't get it right. Thanks.

  0

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted over 1 year ago

  @MelvinAguilar Thanks, seems I have understood what you explained to me. Thanks, I really appreciate it.

  0

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted over 1 year ago

  @MelvinAguilar Adjusted it, please can you check again if i didn't do it right. Thanks.

  0