Design comparison
SolutionDesign
Solution retrospective
Hi everyone! This is my second project and I want you to feel free to leave your advice so I can learn more. I'm super motivated and thanks in advance to the people who are going to take the time to see my code :)
Community feedback
- @darryncodesPosted almost 3 years ago
Hi Juliana,
Really great solution, just a shame the images don't seem to be connected properly.
- this is how relative file paths work
- you could clear up your accessibility report if you swapped your
<h3>
for a<h1>
and used some descriptive HTML elements - swap
<div class="card">
for<main class="card">
and<div class="attribution">
with<footer class="attribution">
All the best!
Marked as helpful3 - Account deleted
Hi Juliana, Hope you're doing good.
Great job.
I just wanna suggest that you add an img tag to your img-illustration div with the right path to the image. It would look like this:
<div class="img-ilustration"> <img src="./images/illustration-hero.svg" alt="Hero illustration"> </div>Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord