What's with all the section elements?! You know you can use divs for layout, right? There is no benefit to using section like this, it just makes the code hard to read for no reason in my opinion.
The solution looks great overall though! Only a few minor issues I can see:
- The main heading should all be one h1.
- The main heading looks quite a lot smaller in your solution compared to the original design. Try to get it closer if you can.
- Those icons are decorative so alt should be empty.
- This has poor accessibility at the moment. Font size must never be in px, use rem. And the media query values should also be defined in rem or em not px. This is important for people who change their default text size.
@guptaujjwal1128
Posted
@grace-snow
Hi
Thanks for the feedback. I agree with your suggestions. Good catches.
One doubt: how to contain two heading with different style in single H1 tag.
Regards Ujjwal Gupta
@guptaujjwal1128 a strong or span on one half set to display block
@guptaujjwal1128
Posted
@grace-snow Thanks, can we connect on discord.