Responsive card section using CSS Grid

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Site looks good in desktop, though you could have used more of the screen's size to display the desktop layout, the mobile layout starts from 1000px going down which seems to much to be used by mobile.

  You already got a great feedback, just going to add some little ones:

  • The first two text should be using a single h1 element, both text are just one phrase so you don't need to use separate heading for each one.
  • Lastly, the alt for the icons on each card should be left empty alt="" since those are just decoration.

  Again, awesome work on this one.

  Marked as helpful

  0

  ---

  

  Ryan Calacsan•200

  @ryancalacsanPosted about 3 years ago

  @pikamart thanks for the feedback! I think I was just moving along quickly and for some reason thought to make the text two different elements instead of just styling the line separately. Will definitely make the change. Thanks again!

  0
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  Hey, this is so flawless, the alignment and all is just right! Kudos! Incase you want to eliminate that accessibility issue, consider using the header tags in a sequential order (h2, h3, h4...) It improves your site's accessibility more so for people that need to use screen readers this issue came about because you used the h2 tag before h1. I like your solution and this is some really good work! Keep on coding.

  Marked as helpful

  0

  ---

  

  Ryan Calacsan•200

  @ryancalacsanPosted about 3 years ago

  @tesla-ambassador Thanks will make those changes. Accessibility is definitely one of the things I am trying to be better about.

  0

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  @ryancalacsan You're welcome!

  0