Design comparison
SolutionDesign
Solution retrospective
- First solution
please give me feedback this is my first submit in Frontend Mentor
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution had generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@Mo-Ramadan997Posted over 1 year ago@0xAbdulKhalid
-
thanks AbdulKhalid this notes helpful for me I will apply it in future
-
thanks again for feedback 😄
0 - @vraj1091Posted over 1 year ago
It is just perfact one please try to add minimum one heading tag in every page because of that web browser can find content easily using heading tag
0@Mo-Ramadan997Posted over 1 year ago@vraj1091 Sure i will take this note in mind
- Thanks for your feedback
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord