Responsive Card NFT using Scss and HTML

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Cristian,

  Excellent solution, really well done!

  Two minor points from me:

  • you could add justify-content: center; min-height: 100vh; to nicely centre your design responsively in the viewport
  • you could clear your accessibility report if you used semantic html like <main> and <footer> also add a <h1>, here is some more info

  All the best!

  Marked as helpful

  0
• 

  Volodymyr Balashov•510

  @volod-onePosted almost 3 years ago

  Hey there! Your component looks good. There is one thing what I want to mention. Basically when you are trying to put your block tag into your inline tag it is seems like bad practice and compiler may complain about it. In your case you have a link inside "card-image" which contains a div tag. Maybe it would be better to display your svg with using css instead of html. Good luck mate!

  Marked as helpful

  0