Frontend Mentor | Responsive card / mobile first coding challenge solution

Community feedback

@Hassiai

Posted over 1 year ago

To center .card on the page using flexbox, replace the height in the .container and with min-height: 100vh.

There is no need to give the body a width and height value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Sumanth Chandana• 720

@sumanth-chandana

Posted over 1 year ago

Hi mate!, congrats🎉 on completing the challenge. Better take care about following points.

Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
Why does alt attribute matter? Read here.
To avoid accessibility issues "All page content should be contained by landmarks" use code as :

 <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why does <main> matter? Read here )

For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:

body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

I hope you will find this Feedback Helpful.

Responsive card / mobile first

Design comparison

Community feedback

Please log in to post a comment

Join our Discord community