Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace<div id="card-wrapper">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Add the alt attribute
alt=" "
to the img tag to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
To center #card-wrapper on the page using flexbox, add min-height: 100vh, display: flex; align-items: center: justify-content: center; to the body .
To center #card-wrapper on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord