Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive card following tutorial with through readme file

aimee 50

@aimeempereira

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the component has been centered properly. But the issue is the content inside the body causes overflow on smaller screens and let people scroll the content, this issue want to be cleared.
  • This is just caused by over usage of margin property, we can use margin if necessary but in this project there's no need to use it
  • Now remove margin from the bodyin css, after setting you can able to see the changes
body {
   margin: 1rem;
}
  • Now the overflow of content has been cleared

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0
P
Christian 390

@UtopicUnicorn995

Posted

looks great.

But I would recommend removing the margin in body to center it better. Anyways great job.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord