Responsive card desing

Community feedback

• 

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  Hey @ganeshcool1,

  Congrats on completing your first FrontendMentor challenge! :)

  Here is some feedback on my side:

  • try using other html tags than div. You have the following <div class="footer"></div>. If I were you, I would just use the <footer></footer> tag.
  • <p class="header">Equilibrium #3429</p> is not really a paragraph. It is a good idea to distinguish paragraphs from titles. Titles are usually put within headers. In this case h1 would be a good fit.
  • think about using CSS custom variables to store colors and font sizes. This will keep your code clean.
  • I can also see that you didn't use the suggested font. In case that wasn't on purpose, there are different ways you can import a font. One way is to put @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@300;400;600&display=swap'); at the top of your css file and then make sure to have this font used by your entire project by adding * { font-family: font-family: 'Outfit', sans-serif; }, where * stands for all and it will apply this font to all your tags.

  Hope this helps! Keep coding! :)

  Marked as helpful

  0
• 

  Ganesh tripathi•30

  @ganeshcool1Posted almost 3 years ago

  thanks for suggestion I am surely implemented all your suggested coding changes...keep guiding me

  0