Responsive Card Design Using CSS and HTML

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  Hi Marco Tsang, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Marco Tsang•50

  @hkmarcootPosted almost 2 years ago

  Hi @AdrianoEscarabote . I have solved the HTML5 landmark problem with your suggestion. Thanks!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The name of the perfume , “Gabrielle Essence Eau De Parfum” is the most important content in your card so it should be wrapped in a Heading Element.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Marco Tsang•50

  @hkmarcootPosted almost 2 years ago

  @vcarames I have added alt tag description, thanks for reminding! I will try your picture element with breakpoints in my next project. I will keep the flaw here to keep track my learning journey.

  0
• 

  P

  Q-bert•210

  @QBERT18Posted about 2 years ago

  Hi! nice solution. If you want to center anything horizontally than you can just use text-align: center property for any block element. The text-align will position any child element in the center of the calling element (div in this case). If you want to center any individual element inside his parent element you can use a css trick margin: 0 auto.

  Vertical Centering is bit differente. There are no out of the box way to center stuff vertically. Thats why you should eather use flexbox or grid. After some challenges here i stated to become more grid user. I had issues with the flexbox expecially when i tried to make 2 same size columns. So maybe you try grid. Because grid doesn't have that problems.

  You can compare your solution to mine https://github.com/QBERT18/product-preview-card-component-main :) Let me know if i could help you bit more. If you have more questions than just ask me :) Best Regards Q-bert.

  Marked as helpful

  0

  ---

  

  Marco Tsang•50

  @hkmarcootPosted almost 2 years ago

  @QBERT18 I am glad you explain the centring to me! Your solution is helpful.

  0