Responsive card component using Flexbox and Sass

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Andres,

  Well done! :D

  I have checked your HTML, a few tips from me:

  • I think you don't have to use two sections in this component because all this project it is a one component so instead of two you can use one IMO;
  • I have read that hgroup tag has been removed from the HTML5 (W3C) specification, but it still is in the WHATWG version of HTML, so instead of it you can use one h1 with two spans inside of it (main-heading and sub-heading);
  • in the second card you have used two spans inside of div, but you can change to the p tag with two spans;
  • text per month should be in the middle of the price.

  That's it from me. Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1

  ---

  

  Andrés Galván•45

  @afgalvanPosted almost 4 years ago

  Thanks for the feedback!

  0