Design comparison
Solution retrospective
Really liked the practice on this component. Need to work on containers still and work on max-width. Learn some new properties like the text-decoration with the line-through. Fun project!
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Cj Rivas, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5
<h1 class="card-title">Gabrielle Essence Eau De Parfum</h1>
To improve the structure of the html document, prefer to wrap all the content with the
main
tag, since this challenge is just a component, it needs amain
tag to know what the main content of the page is!The rest is great!
I hope it helps... 👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord