Design comparison
SolutionDesign
Solution retrospective
What do you think? Any critic would be good. I think my image sizing is off, so if you have any idea how to implement that better, I'm all ears.
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi! 👋
Congratulations on completing this challenge! 🎉
One suggestion I have is to remove the
role="contentinfo"
from thediv
. What is the purpose of doing this? I would not recommend using ARIA attributes unless you have to.I have three recommended videos. The first one tells how hard HTML is (HTML is not easy). The other two talk about modern CSS techniques and approaches.
- Manuel Matuzović - Lost in Translation - YouTube
- Andy Bell – Be the browser’s mentor, not its micromanager - YouTube
- Stephanie Eeckles - Scaling CSS Layout Beyond Pixels - YouTube
I hope this helps! Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord