@VCarames
Posted
Hey, some suggestions to improve you code:
- Implement a Mobile First approach.
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start buildingyour website/content for smaller screen first and then adjust your content for larger screens.
-
Stay away from IDs when naming your content. They are not reusable and are mainly used for JavaScript. Its best practice to use, Classes for your naming convention as classes are reusable, making them ideal for CSS styling.
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires you to use two images for different breakpoints. To properly achieve this, you want to use <picture> element.
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
Source:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
The name of the perfume, “Gabrielle Essence Eau De Parfum” is the most important content in your card. So it has to be wrapped in a <h1> Heading. If this was a larger challenge with more card in the same page, then an <h2> or <h3> heading would be the better choice.
-
The old price is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
To improve the accessibility of your content, you wan to to use em instead of px for you media queries. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
Happy Coding! 👻🎃
