Responsive Card Component - Frontend Mentor

Community feedback

• 

  Lucas 👾•104,300

  @correlucasPosted about 2 years ago

  👾Hello @curtisaallen, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  1

  ---

  

  Juan•10

  @juangalarzaPosted about 2 years ago

  @correlucas Thanks bro!

  1

  

  Lucas 👾•104,300

  @correlucasPosted about 2 years ago

  @juangalarza Hey Juan, then say me if worked for you and if were useful info. Keep it up =)

  0

  

  Juan•10

  @juangalarzaPosted about 2 years ago

  @correlucas I haven't implemented it yet, but it helped me a lot. I'm leaving the old school of css :)

  0

  

  P

  Curtis Allen•400

  @curtisaallenPosted about 2 years ago

  @correlucas Thanks for the recommendation. I thought about doing that when I started coding the card. If, I get sometime I may come back to this project. To make the div ADA accessible, I have added the role and aria label to the div.

  0