Responsive card component, css flex, and box shadow

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Greeting BasemAmr , Congratulation on completing your First Frontend mentor project, your solution looks nice. I think you have done a great work for your first challenge.

  • Replace the heading<h2 class="card-name normal-text">Equilibrium #3429</h2>by <h1> to solve the accessibility issue click here to read more.

  • You should have wrapped "Equilibrium #3429" in an anchor <a>.

  • Setting the alt text for the images <img src="images/icon-ethereum.svg" alt="Clock Icon"> <img src="images/icon-view.svg" alt="Icon View"><img src="images/icon-clock.svg" alt="Ethereum Icon">`to an empty string. That's because the purpose of those images are mostly decorative and need not be announced by assistive technology like screen readers.

  • You can wrap this <span class="normal-text"> Jules Wyvern</span> by an anchor tag .

  You can check my solution here.

  I really hope this feedback helps. Happy coding

  Marked as helpful

  1

  ---

  

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  Hi, @PhoenixDev22 the feedback is very helpful, and I'm going to fix remaining problems thank you very much.

  0