@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Add
min-height:100vhto the.cardto properly center it. -
It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture>
<source media="(min-width:800px)" srcset="yourimage.jpg">
<img src="yourimage.jpg" alt="description">
</picture>
- Use Semantics for the proper design of your code.
<body>
<main>... main content goes here ...</main>
<footer>...</footer>
</body>
-
For
non-decorative imagesgive meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves.". -
Use
responsive units(rem, em, %)from next project. Explore respective use cases on google. -
Replace
widthwithmax-widthto make your card more responsive.
I hope you find this helpful.
Happy coding😄
Marked as helpful
@misaeljoelp
Posted
@NehalSahu8055 Thanks for taking the time to provide feedback. Your observations have been very useful.
