Skip to content
Submitted almost 2 years ago

responsive card

Cousnay•320
@Disney-Banje
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any recommendations about best practices that I should follow on my next projects?

Community feedback

  • Sinisa Vukmirovic•1,690
    @SinisaVukmirovicPosted almost 2 years ago

    Hello!

    Maybe to use more semantic HTML5 elements in your MarkUp, not just <main>. Some of those <div>s could, and should, be substituted with <section> elements, for example. [More on semantic elements] (https://developer.mozilla.org/en-US/docs/Glossary/Semantics)

    Also, good practice is to import Google fonts inside of your CSS file, not HTML. You are setting...

    font-family: sans-serif;

    ...inside of your CSS, right? Makes sense to import it in CSS, too.

    Marked as helpful
    0
    Cousnay•320
    @Disney-BanjePosted almost 2 years ago

    @SinisaVukmirovic thanks for the review

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord