Responsive Calculator - CSS + JS

Community feedback

• 

  Devika Sujith•175

  @DCoder18Posted over 2 years ago

  Hi Ryan, Good job! Regarding your question about the percentage buttons, I used something called data attributes. It allows you to store custom data from within the html itself!

  For example, I have the following percentage button with a data attribute I called data-tip-amount.

  <button type="button" data-tip-amount="5" >5%</button>

  And then in javascript, I stored the tip amount in a variable using the getAttribute method.

  tip = Number(btn.getAttribute('data-tip-amount'))

  Hope you find this helpful :)

  Marked as helpful

  0
• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 2 years ago

  Hello Ryan! Solid work!

  I just have a quick improvements.

  • When comparing values, it's preferable to always use strict equal(===) instead of loose equal(==). Strict equal prevent your values type to be coerced or converted to matching type. So, it's better because it's explicit about types.
  • You should switch the top most wrapper div with a main tag. So, your contents are inside a landmark.
  • You should increase all heading level below h1 by 1 to prevent skipping heading level.

  I hope it helps! Cheers!

  Marked as helpful

  0