Design comparison
SolutionDesign
Solution retrospective
Any feedback would be welcomed.
Community feedback
- @better5afePosted about 1 year ago
Hi there!
First of all, congrats on finishing the project! I hope you had a lot of fun making it!
Please find some feedback from my side below:
- if you submit many digits, they are overflowing from the calculator's display - you can try to either stop adding new numbers after a certain amount or you can also consider making the font smaller once there are more and more digits
- if you press 0 and then another digit, it's displayed as e.g. '03' - you can check if the display value is empty and if the pressed number is equal to 0 and return if that condition is met
- if the display is empty and you press the decimal point, it's being added as '.' - you can consider adding a 0 right before the decimal point in that case
- it is possible to add multiple decimal points in a row
- it is possible to key in multiple operators without any digits in between
- it would be also a nice idea to block the possibility of adding operators if the display is empty (with - as an exception)
- you can consider disabling the possibility of dividing by 0 or throwing an error in that case
That's all what I've noticed. Hope it helps and once again - congrats!
Happy Coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord