Responsive blog--preview-card

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @djamkenny!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  1

  ---

  

  Enoch Beamahn•80

  @djamkennyPosted 10 months ago

  @danielmrz-dev Thank you so much your feedback has made me realise that it not just about what appears on the screen but the importance of semantic and cascading

  1

  

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  @djamkenny

  I'm glad I could help 😊

  0
• 

  Dongmo Shu•280

  @dongmo-shuPosted 10 months ago

  Hello @djamkenny

  Congratulations on completing the challenge.

  Due to the nature of this challenge, I recommend you work on the mobile-first approach. That is, complete the mobile design, then move on to the desktop version.

  The layout information available in the file style-guide.md serves as a guide, to know the exact dimension needed for your media query.

  For responsive website design, the FEMentor community have an article on the topic which is beginner-friendly. I recommend you read it

  I hope this is helpful

  Marked as helpful

  1

  ---

  

  Enoch Beamahn•80

  @djamkennyPosted 10 months ago

  @Singraft You feedback is going a long way to make me a good developer.

  1
• 

  Faith Akanga•70

  @FaithNAPosted 10 months ago

  Hello. Good job on your work. For your problem of your output not fitting all devices, you could use @media in your styles to determine how the output should look like on devices of other sizes. Here is a sample code:

  
  @media(max-width: 375px){
        div{
          max-width: 275px;
          height: 400px;
        }
        body{
          font-size: 13px;
        }
          img{
          max-width: 250px;
          max-height: 259px;
          margin-top: 10px;
         }
          h1{
          font-size: 15px;
      }
  

  Initially, the font size for h1 in my style was 22px. After using @media, the font size for a device of width 375px and less will be 15px. Also, the initial width of the div was 350px, but for a device of width 375px it will be 275px as seen in the code.

  Hope this helps!

  Marked as helpful

  0