Responsive Blog Review Card

Community feedback

• 

  Jye Harry•20

  @jyeharryPosted 3 days ago

  Personally, rather than having BEM class names that start with "blog", I would've continued using class names that start with "card" as they're still part of the card "block".

  Instead of the card being a <div>, I made mine an <article> to make it more semantic and accessible.

  Lastly, your media query which adds padding to the <main> tag only kicks in once the screen reaches 375px, but above that the card briefly touches the edges of the screen. It might be better to just always have that padding on the container.

  Adding to that, you could avoid using media queries to change the font size by instead using clamp() which makes the font size change fluidly. :)

  0

  ---

  

  Bassel || باسل•60

  @BasselfathyPosted 1 day ago

  @jyeharry Thank you for these tips, I'm sure it will improve the code quality.

  0