Design comparison
SolutionDesign
Community feedback
- @JYLNPosted 4 months ago
Great work on your solution! Even though this is a simple project, I think it's great practice for using and understanding Next, so I commend you there.
A few things I noticed while looking through your code that could potentially use some improvement:
- You used explicit arbitrary values for your sizes throughout the project. Ideally, I would recommend that you use relative values (rem/em) so that your sizes scale properly based on different root base sizes. As well, I would recommend that you stick closer to Tailwind's utility classes (at least with this project, they fit rather nicely). I usually only revert to using arbitrary values in Tailwind classes if none of their provided utility classes produces the result I want.
- Your component could use a bit more spacing and variety of font sizes to fit the design slightly better. For example, I think that the root card element could use a bit of extra padding, there could be more gap between the content elements of the card, and I think the
Learning
tag and published date could be a little smaller. The Figma design file provided with this project gives some great insight on what that spacing and sizes could look like.
Overall, keep up the good work!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord