Design comparison
Solution retrospective
It was a pretty easy challenge.
What challenges did you encounter, and how did you overcome them?I didn't encounter any challenge.
Community feedback
- @SaruMakesPosted 5 months ago
I like your take on the project! I think your code structure is cleaner than mine. Well done!
A small comment, and it might be something you're already aware of, but instead of writing
line-height: 1rem;
for example, you can simply writeline-height: 1;
instead. Without therem
unit, the value becomes proportional to the text. So a line height of1.2
is 1.2 times the size of whatever thefont-size
is. I find it to be a bit more intuitive and easy to reuse, compared to directly declaring units inrem
orpx
.Of course, feel free to disregard this. It is merely an observation :-)
Marked as helpful0@Macnelson9Posted 5 months ago@SaruMakes Oh wow, I didn't know that. Thank you for this tip. I'll be sure to implement this in my future projects. Thanks.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord