Design comparison
Solution retrospective
I liked using :not()
to keeping the author's name unchanged on smaller screens.
I started by styling each text element individually, but I noticed that the font size changed on smaller screens. I didn’t want to manually adjust each one, so I set up font presets instead.
What specific areas of your project would you like help with?I welcome all feedback! 😊
Was setting up the text presets a good solution?
Community feedback
- @StroudyPosted about 2 months ago
Hello again, Incredible work on this! You’re making great strides, and I have a couple of suggestions that might push it even further…
- These
<span>
should really have semantic tags like headings (<h1> to <h6>
) and paragraphs (<p>
) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.
<span class="category text-preset-3 bold">Learning</span>
-
Using
font-display: swap
in your@font-face
rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear. -
I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
-
This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation),
<meta>
description tag missing that helps search engine determine what the page is about, Something like this<meta name="description" content="description goes here" />
You’re doing so well, and I hope this feedback is helpful! Keep honing your skills and remember to enjoy the process—you’re on a great path. Stay motivated, and happy coding! 🎯
0 - These
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord