Design comparison
Community feedback
- @rayaattaPosted 12 months ago
Hello πFlorian, congratulations on completing this challenge π
I have some suggestions you might find interesting.
1 Try to make your html more Semantic by wrapping the main page content inside a
<main>
tag . Replace<div id="container">
With<main id="container">
. This changes nothing visually but Using it makes all the difference. Using semantic markup improvesSEO
And user experience (accessibility) for people using assistive technology such as screen readers.
2 I noticed
<p class="foundations">HTML & CSS foundations</p>
This is actually supposed to be a heading you should replace it with
<h1 class="foundations">HTML & CSS foundations</h1>
3 In order to center the card on any screen add
min-height:100vh;
In the css for body
I hope this helps π
Your solution looks neat π
Happy coding βοΈ
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord