Design comparison
Solution retrospective
First Frontend Mentor project! Went pretty smoothly, the one thing I had issue with is trying to make it responsive. I first tried to add media queries to my style.css but that was not working so I created a separate queries.css for the @media queries.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @chleighton1!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h3>
. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>
to<h6>
tags are used to define HTML headings.š
<h1>
defines the most important heading.š
<h6>
defines the least important heading.š Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
Marked as helpful0@chleighton1Posted 10 months agoThank you @danielmrz-dev that is a great tip!
I always assumed it was mostly just about size but I will definitely take this into future projects!
Thanks again!
0 - In order to make your HTML code more semantic, use
- @darley-santosPosted 10 months ago
"Oh, you did great! How did you handle hover effects? If you use responsive units like max-width, you wouldn't even need to use media queries."
0@chleighton1Posted 10 months agoHi @darley-santos!
I actually did not use any hover effects and just used the 'active' pseudo-class for the drop shadow and title change. Media queries I used just to make it responsive for mobile
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord