Design comparison
Community feedback
- @saularangurenPosted 6 months ago
Greetings, your solution is really impressive, however, we can improve it by changing the following aspects that I will show you, let's start by eliminating the lines of code that are totally unnecessary
Delete these lines of code inside the html file:
<link rel="preconnect" href="https://fonts.googleapis.com"> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> <div class="container"> the last </div>
your html code should look like this:
<!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Frontend Mentor | Blog preview card</title> <link rel="stylesheet" href="css/style.css"> <link rel="icon" type="image/png" sizes="32x32" href="./assets/images/favicon-32x32.png"> <link href="https://fonts.googleapis.com/css2?family=Figtree:ital,wght@0,300..900;1,300..900&display=swap" rel="stylesheet"> </head> <body class="container"> <div class="card"> <div class="card-content"> <img src="assets/images/illustration-article.svg" alt="illustration medium" class="img"> <p class="learn">Learning</p> <p class="publish-date">Published 21 Dec 2023</p> <p class="topic">HTML & CSS foundations</p> <p class="sub-content">These languages are the backbone of every website, defining structure, content, and presentation.</p> <div class="user-card"> <img src="assets/images/image-avatar.webp" alt=""> <p>Greg Hooper</p> </div> </div> </div> </body> </html>
do not break the lines of code into several parts, just because it is not visible on the screen, it is bad practice and if you want you can delete the files:
style-guide.md
ANDREADME-template.md
, when you finish developing your projecthappy codign 😁
1@VictorEZCodesPosted 6 months ago@saularanguren haha thanks, i just copy pasted whatever google font gave me 😂😂
thanks for the feedback again
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord