Design comparison
Solution retrospective
I am most proud of thinking through the design structure before implementing the styling. Instead of rushing through implementation, like in the previous assignment, I was able to prevent clumsy mistakes from happening again.
What challenges did you encounter, and how did you overcome them?Responsive typography and getting the card to be similar dimensions as the demo. I figured out that line height is not inherited from parent elements, which is why my card was a different size compared to the demo. For the responsive typography I looked into the css clamp function.
What specific areas of your project would you like help with?I would like to keep the attribution container but I'm using height:100vh on the body element so when I inspect element, the attribution overlaps the card.
Community feedback
- @mkborisPosted 2 months ago
The .attribution overlaps the .card because you are using
position: absolute
. To fix this give the body aflex-direction: column
and agap: 1.5rem
to give some spacing between the card and the attribution and remove theposition: absolute
from the attribution. Also, change theheight
of the body tomin-height
Usingmin-height
ensures the content can grow beyond the viewport height if necessary, whileheight
would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height.Marked as helpful1 - @abdelrhmanKhPosted 3 months ago
awesome work my friend also you have made the design exactly great work keep up the work šŖšš
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord