Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I was able to code this project without examining another member's code.
What challenges did you encounter, and how did you overcome them?Honestly, I was able to sort through everything without much difficulty. I just built off of the previous exercise.
What specific areas of your project would you like help with?I was able to get the hover state to work. I was not sure what was supposed to be in a focus state though.
Community feedback
- @StroudyPosted 2 months ago
Hey this is a great solution and you should be proud, A Few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- If you want to centre a container left and right it best to use
margin-inline: auto;
, Inline means left and right, Normal margin is Up, Down, Left and Right,
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
0 - Missing a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord