Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @UmerNasir-2000!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  0

  ---

  

  Muhammad Umer Nasir•50

  @UmerNasir-2000Posted 10 months ago

  @danielmrz-dev Thanks for the suggestion, I think it makes sense also. I'll change it in my markup as well.

  0
• 

  Velin Dankov•160

  @IvelinDankovPosted 10 months ago

  Hi, Muhammad Umer Nasir! Your card look pretty good! Maybe your article should be just a div element with class card for example. But I think you makes a good job.

  0

  ---

  

  Muhammad Umer Nasir•50

  @UmerNasir-2000Posted 10 months ago

  @Velingd Thanks for the suggestion, but I think an article makes sense as its more semantic.

  0