@haquanq
Posted
Yo @Joewanaaa,
My last comment has one important point which is keep your HTML simple and clean (avoid unnecessary wrapping, especially div wrapping). But instead you have replaced all div with section 😭
So to understand if you are using redundant wrapping, just try to delete one section and ask yourself 2 question:
- Does the layout stay the same?
- Does the content still semantically meaningful?
As section or article must have a heading h1-h6 along with it and some content next to the heading which will make the section/article become meaningful. You are nesting section (4 times) and it is unnecessary, the article pretty much served the purpose.
You can find this solution on my Github repo if you would want more references!
Keep it up and happy coding!!!
Marked as helpful
@Joewanaaa
Posted
@haquanq i know right! When you thought I understand what you told me last time turns out I just changed the divs into section 🤣I made it even worst! 😭
But seriously, I really appreciate this! Thank you so much for your feedback 🫶🏼 and I will definitely look into your Github repo for references. I still have a lot to learn please don’t get tired giving me lots of feedback 😆tysm!
