P
Steven Stroud• 4,100
@Stroudy
Posted
Hey great job getting it so close to the original, some things I noticed,
- Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Missing a
<meta>
description tag for SEO purposes, - You have a
<h4>
tag above a<h3>
, The<h1>
to<h6>
tags are used to define HTML headings,<h1>
defines the most important heading.<h6>
defines the least important heading. - Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- You should add a
font-display: swap;
property to your@font-face
, Leverage the font-display CSS feature to ensure that text is user-visible while web fonts are loading, Increasing performance.
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
0