@DanCodeCraft
Posted
Hey @Thessssift, good job. It's a good starting point the way it is now.
Design:
- Centralize the main container on the screen. You can do that with CSS, in the body.
- The colors are a little bit off when hovering over the buttons. The same goes for the location.
- The font size and proportions are important to create a good hierarchy, leading your potential customer to where you want to.
Code:
- The first thing I noticed, is that you did not make a CSS reset. This should become a good habit of yours.
- Giving classes to everything you write in HTML is a good idea as well. Imagine you have a longer project. It would be just too difficult to manage the styling this way.
- The buttons could be done with a <a> or <button> element. For this page specifically, it wouldn't do much, but for accessibility purposes, and in a real-life scenario, having each as a paragraph would not work.
- Adding small details like a transition for when hovering over buttons is one extra line, but such a good result!
- Also, consider learning about different unit measures.
Keep up the good work.
Marked as helpful
@Thessssift
Posted
@DanCodeCraft , Thank you for time . Super useful feedback .