Design comparison
Solution retrospective
My challenge is to make the project exactly like the design. I hope it's a little bit like that.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @Webprojon!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, and since that is the main title of the screen, you can replace the
<h2>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, since the card is all we have on the page, use
main
to wrap the main content instead ofsection
.
All these changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@WebprojonPosted 11 months agoThank you Mr @danielmrz-dev I've changed it a bit :)
1@danielmrz-devPosted 11 months ago@Webprojon
I'm glad I could help π
If my first comment was useful, please don't forget to mark it as helpful! It helps me with the points on the plaftform π
Marked as helpful0 - For semantic reasons, and since that is the main title of the screen, you can replace the
- @Jwalt95Posted 11 months ago
I realised that when I touch the card even if I don't touch the section that was supposed to become yellow, the section change to yellow. After that you did a good job.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord