
Design comparison
Community feedback
- P@makogeborisPosted 2 months ago
Great work, some suggestions
- Use an
img
instead of anobject
,object
is typically used to embed external content - The
header
tag is often used for introductory content and it might not be necessary here as this is just a simple card, you can leave the image as it is or wrap it in a div - Use a separate file for your CSS as it improves maintainability.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
Hope this helps, Good luck!
Marked as helpful1@JanespotPosted 2 months ago@mkboris thank you so much for the feedback. I will update as you have suggested immediately.
1 - Use an
- @deusPridePosted 2 months ago
This project include a semantic tag,is accessible, I am open to any contribution in order to improve it.
Marked as helpful0@JanespotPosted 2 months ago@deusPride Thank you for the review. I am open to any improvements too :-)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord