Design comparison
Solution retrospective
I completed this challenge as apart of the introductory learning path and had a lot of fun with it. I feel very confident in the accuracy of the sizing, and responsiveness of both the font-sizes and the width of the card itself.
What challenges did you encounter, and how did you overcome them?I had no challenges with this, the area I spent the most time on was making sure the padding and margins lined up with the design.
What specific areas of your project would you like help with?I would be interested to hear everyone's ideas on how I went about the usage of CSS variables and my padding, margin, and gaps. Specifically how I went about spacing the body section of the card, although the layout doesn't change I used grid to be able to control the gap in between all of the elements to prevent myself from having to type margin-top: 0.75rem every time and as an alternate to using the :not(:last-child) selector. Not sure if this is a great practice or not. Thanks everyone!
Community feedback
- @DarkstarXDDPosted 5 months ago
- You don't need the layout to change in order to use flex or grid. It's common practice to use flex or grid in order to use the
gap
property. What you have done is correct and gives a clean result. - You should change the card
width
to bemax-width
. It won't be a deal breaker in this case but get into the practice of usingmax-width
instead of the fixedwidth
.
1@baileyfrye1Posted 5 months ago@DarkstarXDD thanks for the reply! Glad you caught that I forgot to use max-width. I had actually started with max-width but when I was figuring out my vw size for my clamp function I ended up switching it temporarily to width to see if that changed anything but I forgot to change it back when I submitted the solution. I appreciate your advice on the flex/grid usage, I’ve always saved using them unless I know I’m going to be changing the layout based on a breakpoint so using it in this way was slightly new for me. Thanks for the help!
1 - You don't need the layout to change in order to use flex or grid. It's common practice to use flex or grid in order to use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord