@DylandeBruijn
Posted
@KevinBermudezC
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
Try making your solution responsive.
-
position: relative
is not necessary on your card. -
Try using relative CSS units like
rem
andem
. -
Be careful with setting a fixed
height
andwidth
on an element, this will cause overflow issues. Example:
.category {
background-color: var(--primaryYellow);
padding: 4px 8px;
border-radius: 4px;
font-weight: bold;
width: fit-content;
height: 29px;
}
Try putting more text in the .category
element and you'll see the problem.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful